Add prebuild for macos arm64, enable prebuilds to be run individually. #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase to build on node 22. add runner macos-latest.
|
latest run with both PRs in place here: |
|
ahh... if I test without the container in a separate test workflow, it does not fail? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
'["ubuntu-latest", "windows-latest", "macos-13", "macos-latest"]'.for best effect, combine with #2450 to result in smaller prebuilds
I note that 2 tests are failing during prebuild - on the original and on this branch (at least on linux - maybe a font issue). Maybe we should build the libraries from source, as test on main repo is not failing?
Also note #2354 - almost identical changes for actually building on arm64. But I have not included signing. I have never needed to sign a .node or a library before? - but then I don't have an M1/M2 mac.
@zbjornson @jamesbvaughan - pls. comment or combine the two PRs?